feat: add TF_VAR check and conventional commit lint workflows #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a workflow that checks that the GitHub workflow Terraform variables definied as TF_VAR prefixed environment variables have a matching `variable` definition in the codebase. This will help prevent accidental misconfigurations between the workflows and Terraform code. Add a workflow that makes sure all commits follow the conventional commit style. This will help ensure that the Release Please changelog contains all PRs.
patheard
changed the title
craigzour
previously approved these changes
May 17, 2024
craigzour
approved these changes
May 17, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds the following two workflows:
conventional-commit-lint: check all commits follow the conventional commit style. This will help ensure that the Release Please changelog contains all PRs.terraform-variable-check: checks that the GitHub workflow Terraform variables defined asTF_VAR_prefixed environment variables have a matchingvariabledefinition in the codebase. This will help prevent accidental misconfigurations between the workflows and Terraform code.Once this merges, if a PR contains any commits that do not follow the conventional commit style, those commit messages will need to be rewritten with
git rebaseorgit commit --amend.